pfc tests migrated to snappi #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutshkumr
requested changes
Jun 7, 2021
| """ | ||
| duthost = duthosts[rand_one_dut_hostname] | ||
| return (duthost.host.options['variable_manager']. | ||
| _hostvars[duthost.hostname]['secret_group_vars'] |
There was a problem hiding this comment.
why do we have secret_group_vars ? doesn't seem to be used in ixia_api_serv_port
There was a problem hiding this comment.
there is some update in the library end, have to add this to ixia_api_serv_port also..I will add that in separate PR and same is informed to Wei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Migration of PFC tests from
abstract open traffic generatortosnappiSummary:
Test case(new/improvement)
Type of change
Approach
What is the motivation for this PR?
The motivation for this PR is to migrate the tests that are written with
abstract open traffic generatortosnappiHow did you do it?
Replaced the code where abstract is used to snappi
How did you verify/test it?
verified all the tests in sonic-mgmt using pytest with DUT and IXIA connections
snappi version used for the development of tests
snappi[ixnetwork]==0.4.0