Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for the last commit #135

Merged
merged 6 commits into from
Sep 27, 2024
Merged

fix for the last commit #135

merged 6 commits into from
Sep 27, 2024

Conversation

asalmgren
Copy link
Contributor

No description provided.

ajnonaka
ajnonaka approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ajnonaka ajnonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will pass regression. Shall we merge or wait on the CI tests to all work?

@WeiqunZhang
Copy link
Member

We can rerun the tests after AMReX-Codes/amrex#4169 is merged.

@asalmgren asalmgren merged commit e8f071a into AMReX-Fluids:development Sep 27, 2024
12 checks passed
@asalmgren asalmgren deleted the fix_for_last_commit branch September 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@ajnonaka ajnonaka ajnonaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asalmgren @WeiqunZhang @ajnonaka