BCType::foextrap as default for (density, BC::slip_wall) combination when advection_type == "BDS" #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnonaka
approved these changes
Aug 1, 2024
|
Hold off on merging - we should consider making all scalars operate the same way. |
ajnonaka
reviewed
Aug 1, 2024
src/boundary_conditions/README.org
Outdated
Comment on lines
7
to
9
| | rho | foextrap | foextrap | ext_dir | foextrap | if (advection_type == "BDS") foextrap | | ||
| | | | | | | else hoextrap | | ||
| | scalar | foextrap | foextrap | ext_dir | foextrap | hoextrap | |
There was a problem hiding this comment.
Suggested change
| | rho | foextrap | foextrap | ext_dir | foextrap | if (advection_type == "BDS") foextrap | | |
| | | | | | | else hoextrap | | |
| | scalar | foextrap | foextrap | ext_dir | foextrap | hoextrap | | |
| | rho | foextrap | foextrap | ext_dir | foextrap | if (advection_type == "BDS") foextrap | | |
| | | | | | | else hoextrap | | |
| | scalar | foextrap | foextrap | ext_dir | foextrap | if (advection_type == "BDS") foextrap | | |
| | | | | | | else hoextrap | |
ajnonaka
reviewed
Aug 1, 2024
ajnonaka
approved these changes
Aug 1, 2024
|
The velocity uses hoextrap for the tangential components for slip wall. Would that also be incorrect with BDS? |
|
hoextrap for BDS + velocity is fine - we don't have local min/max constraints. |
siddanib
force-pushed
the
bds_rho_sw_default
branch
from
a6eb09a
to
ab8aab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
BCType::foextrapas the default type for density and tracer atBC::slip_wallboundary only whenadvection_type == "BDS". Also made a minor change in docs (src/boundary_conditions/README.org) for (scalar/density, sw) combination.