Tidied up nested namespace in Utilities for clang-tidy #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lities.H from PelePhysics.H.wq
|
Can you update your PeleLMeX pull request to use this version of PelePhysics so we can verify that this resolves the clang-tidy issues before merging? |
baperry2
approved these changes
Nov 8, 2024
terencelehmann
pushed a commit
to ITV-RWTH/PelePhysics
that referenced
this pull request
Nov 14, 2024
* pin intel-oneapi version in CI (AMReX-Combustion#541) * Bump Submodules/amrex from `8349789` to `00e6f75` (AMReX-Combustion#540) Bumps [Submodules/amrex](https://github.com/AMReX-Codes/amrex) from `8349789` to `00e6f75`. - [Release notes](https://github.com/AMReX-Codes/amrex/releases) - [Commits](AMReX-Codes/amrex@8349789...00e6f75) --- updated-dependencies: - dependency-name: Submodules/amrex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bruce Perry <[email protected]> * Make EOS functions templates to allow for CellData as an argument (AMReX-Combustion#536) * template for celldata in EOS * static asserts in templates * templating for RY2 functions for all EOS * Fix clang-tidy (AMReX-Combustion#535) * fix unused variable * free shared ptr for manfunc parm --------- Co-authored-by: Marc T. Henry de Frahan <[email protected]> * Unit conversions (AMReX-Combustion#539) * Utilities and unit conversions * Formatting * 2 structs and renamed functions to avoid macros issue * Templating and namespaces * Added Utilities to Docs * Overload instead of templating * Fixed nested namespaces for clang-tidy error in PeleLMeX, removed Utilities.H from PelePhysics.H.wq (AMReX-Combustion#545) * Update CI to ubuntu-24.04 (AMReX-Combustion#546) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bruce Perry <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <[email protected]> Co-authored-by: Dave Montgomery <[email protected]> Co-authored-by: Jon Rood <[email protected]>
baperry2
added a commit
that referenced
this pull request
Dec 23, 2024
* ceptr: Added functionality for reading and converting PLOG reactions. * Do formatting with black * Run isort and flake8 * Latest upstream pull (#2) * pin intel-oneapi version in CI (#541) * Bump Submodules/amrex from `8349789` to `00e6f75` (#540) Bumps [Submodules/amrex](https://github.com/AMReX-Codes/amrex) from `8349789` to `00e6f75`. - [Release notes](https://github.com/AMReX-Codes/amrex/releases) - [Commits](AMReX-Codes/amrex@8349789...00e6f75) --- updated-dependencies: - dependency-name: Submodules/amrex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bruce Perry <[email protected]> * Make EOS functions templates to allow for CellData as an argument (#536) * template for celldata in EOS * static asserts in templates * templating for RY2 functions for all EOS * Fix clang-tidy (#535) * fix unused variable * free shared ptr for manfunc parm --------- Co-authored-by: Marc T. Henry de Frahan <[email protected]> * Unit conversions (#539) * Utilities and unit conversions * Formatting * 2 structs and renamed functions to avoid macros issue * Templating and namespaces * Added Utilities to Docs * Overload instead of templating * Fixed nested namespaces for clang-tidy error in PeleLMeX, removed Utilities.H from PelePhysics.H.wq (#545) * Update CI to ubuntu-24.04 (#546) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bruce Perry <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <[email protected]> Co-authored-by: Dave Montgomery <[email protected]> Co-authored-by: Jon Rood <[email protected]> * Adding example mechanism for PLOG evaluation * Bump Submodules/amrex from `00e6f75` to `f27eb69` (#550) Bumps [Submodules/amrex](https://github.com/AMReX-Codes/amrex) from `00e6f75` to `f27eb69`. - [Release notes](https://github.com/AMReX-Codes/amrex/releases) - [Commits](AMReX-Codes/amrex@00e6f75...f27eb69) --- updated-dependencies: - dependency-name: Submodules/amrex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * speciesNames for Manifold EOS (#542) * simplify templated functions in EOS.cpp * rearrange template specializations in EOS.cpp so they are all in header; improve speciesNames function for manifold * SYCL ifdef for manifold speciesnames * pass host eosparm to reactors * ignitionDelay: remove one invalid call for manifold eos * fix dumb bug * clang-tidy unused arguments * ceptr: create pressure-specific folders for plog mechanism, move plog_pressure var into mechanism object * ceptr: implement command line and list options to specify plog pressure * ceptr: Add plog mech to list_mech * ceptr: Copy Make.package to the plog subfolder * add docs on plog mechanism conversion * fix typo fix another typo --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Thomas Howarth <[email protected]> Co-authored-by: Bruce Perry <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <[email protected]> Co-authored-by: Dave Montgomery <[email protected]> Co-authored-by: Jon Rood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent commit failed to pass the clang-tidy test in PeleLMeX. This PR should fix the problem. Also, I removed Utilities.H from PelePhysics.H per @baperry2's request. To include unit conversions in PeleLMeX or C we'll need to add Utilities.H to the associated PeleLMeX.H (or PeleC.H) headers as is done with the other utilities. This works in my local PeleLMeX branch.