Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SUNDIALS to 7.1.1 #531

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Update SUNDIALS to 7.1.1 #531

merged 8 commits into from
Oct 8, 2024

Conversation

jrood-nrel
Copy link
Contributor

No description provided.

@jrood-nrel
Copy link
Contributor Author

#530

@jrood-nrel jrood-nrel marked this pull request as ready for review October 7, 2024 22:00
@jrood-nrel jrood-nrel requested review from marchdf and baperry2 October 7, 2024 22:00
@jrood-nrel
Copy link
Contributor Author

AMReX-Combustion/PeleC#854 is testing this for PeleC.

baperry2
baperry2 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReactEval gives identical results before and after this PR (both with and without use_erksep).

The PeleC test that is failing should pass if you pull in the latest PelePhysics changes where I fixed that nullptr issue.

@jrood-nrel jrood-nrel enabled auto-merge (squash) October 8, 2024 16:21
@jrood-nrel jrood-nrel merged commit 45ae8ba into AMReX-Combustion:development Oct 8, 2024
9 checks passed
@baperry2 baperry2 mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baperry2 baperry2 baperry2 approved these changes

@marchdf marchdf marchdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrood-nrel @marchdf @baperry2