-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
surfchem - modified ck,py, production.py, utilities.py and converter.py #486
base: development
Are you sure you want to change the base?
Conversation
@jAnirudh can you rebase your branch on the latest? Once this looks good, I can update the qss chems as well. |
Just a thought: as this work will be implemented over a series of PRs, maybe it would be helpful to open an issue to track the progress and plans, similar to what we did here: #446 |
@baperry2 Sure, I'll put together a plan and open an issue. Meanwhile, @marchdf could you please regenerate the qss mechanisms for me? The qss files are still somehow changing on my linux box. |
@nickwimer and @jAnirudh Does this diff look right for the QSS mech? I am a little confused by the numbers. Actually maybe it's ok. Though I would want a second pair of eyes on this. I pushed the changes if you want to see them all. |
I had introduced |
@jAnirudh and @nickwimer I regenerated the QSS mechs with the latest. Feels like we need to confirm that all is well. |
Hi @marchdf @baperry2 @nickwimer could you please share your comments on this PR for review/merge? Also tagging @ndeak here. Thanks. |
Reworked the
CEPTR
modules generatingmechanism.cpp
to work with heterogeneous reaction mechanisms.ck.py
:ckncf
,cksyme_str
,cksyms_str
,ckkfkr
production.py
:progress_rate_fr
utilities.py
: Addedget_function_prefix
,get_phase
,def get_element_id
,get_atomic_weight
,get_element_names
methodsNUM_QSS_GAS_SPECIES
preprocessor directive toconverter.py
along with changes corresponding to above additions/modifications