Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PeleMP docs into PelePhysics #449

Merged
merged 55 commits into from
Dec 7, 2023
Merged

Move PeleMP docs into PelePhysics #449

merged 55 commits into from
Dec 7, 2023

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Dec 6, 2023

No description provided.

Landon Owen added 30 commits December 6, 2023 09:01
…eckpoint data, changed comments for SprayParticles.H to match doxygen format in case that ever gets implemented, removed SprayWalls.cpp file, added SprayIO.cpp file
@marchdf marchdf mentioned this pull request Dec 6, 2023
21 tasks
@marchdf marchdf changed the title Moving PeleMP docs into PelePhysics Move PeleMP docs into PelePhysics Dec 6, 2023
@marchdf marchdf marked this pull request as ready for review December 6, 2023 22:17
Copy link
Contributor

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with merging this as is because we can't really fix the incorrect paths to cases until the cases get moved anyway.

Single Droplet Tests
--------------------

Single droplet tests are performed and compared with computational or experimental results published in literature. These tests are setup in ``PeleProduction/PeleMPruns/single_drop_test``. To run a test case, simply open ``Validate.py`` and set the case name from the table below ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of date and never made it into the main PeleProduction branch. But when we bring the cases over to PeleC and PeleLMeX, being able to reproduce these results would be a good objective.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes that's a good point and a good objective

@marchdf marchdf merged commit 262ae76 into development Dec 7, 2023
9 checks passed
@marchdf marchdf deleted the mp-docs branch December 7, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants