Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eosparm support in PeleLMeX #414

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

baperry2
Copy link
Collaborator

@baperry2 baperry2 commented Sep 13, 2024

Progress toward merging the manifold modeling stuff into PeleLMeX

Pass eosparm as argument into all EOS functions. Right now this is not necessary because it is only used by Manifold EOS, but this paves the way for that and should not negatively impact anything.

  • Does not yet support all Efield functions (but because eosparm is not needed for non-manofold EOS, this does not impact functionality)
  • FlameSheet case shows example of how eosparm can be used in problem files for bcnormal/initdata. This will have to be added to any case to be run with manifold EOS, but is done in a way that does not break existing cases.

@baperry2 baperry2 force-pushed the manifold-final-rebase branch from 9016162 to db4d0c0 Compare September 13, 2024 23:42
@baperry2 baperry2 changed the title WIP: Manifold model support in PeleLMeX WIP: eosparm support in PeleLMeX Sep 16, 2024
@baperry2 baperry2 marked this pull request as ready for review September 16, 2024 21:01
@baperry2 baperry2 force-pushed the manifold-final-rebase branch from c30bcdb to a50c552 Compare September 17, 2024 16:54
@baperry2 baperry2 changed the title WIP: eosparm support in PeleLMeX Eosparm support in PeleLMeX Sep 17, 2024
Source/PeleLMeX_DeriveFunc.cpp Show resolved Hide resolved
@baperry2 baperry2 enabled auto-merge (squash) September 23, 2024 20:29
@baperry2 baperry2 merged commit af2853a into AMReX-Combustion:development Sep 23, 2024
24 checks passed
@baperry2 baperry2 deleted the manifold-final-rebase branch October 8, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants