Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset time and nsteps #402

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

SreejithNREL
Copy link
Collaborator

Capability to reset (or not) time and nsteps after restarting from a plot file

@SreejithNREL SreejithNREL requested a review from baperry2 July 26, 2024 20:16
@@ -256,6 +256,7 @@ PeleLMeX algorithm
peleLM.deltaT_tol = 1e-10 # [OPT, DEF=1.e-10] Tolerance of the deltaT solve
peleLM.evaluate_vars =... # [OPT, DEF=""] In evaluate mode, list unitTest: diffTerm, divU, instRR, transportCC
peleLM.do_patch_flow_variables = false # [OPT, DEF=false] Enable user-defined flow variable patching after reading a plot solution file
peleLM.do_reset_time = 1 # [OPT, DEF=1] Resets time and nsteps to 0 after restarting from a plot file. (Warning: plot file will be rewritten if not renamed and argument value = 0)
Copy link
Collaborator

@baperry2 baperry2 Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about calling this peleLM.initDataPlt_reset_time so that it's obvious this setting only applies when initializing from a plt file? And a similar change for peleLM.do_path_flow_variables. Also, let's move these control entries to immediately below amr.initDataPlt in the documentation to make the association even more clear.

Copy link
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the minor change requested, so just go ahead and merge after making that change.

@baperry2 baperry2 enabled auto-merge (squash) August 5, 2024 17:49
@baperry2 baperry2 merged commit 40501b5 into AMReX-Combustion:development Aug 5, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants