Print IntVect values in repr #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Oct 11, 2024
| [iv_name](const iv_type& iv) { | ||
| std::stringstream s; | ||
| s << iv; | ||
| return "<amrex." + iv_name + s.str() + ">"; |
There was a problem hiding this comment.
Would this be more natural?
I forgot what the << for iv implements
Suggested change
| return "<amrex." + iv_name + s.str() + ">"; | |
| return "<amrex." + iv_name + ", " + s.str() + ">"; |
There was a problem hiding this comment.
Either way is fine. As I have it, it would print something like
<amrex.IntVect(10,20,30)>
versus
<amrex.IntVect, (10,20,30)>
|
@atmyers can you please take the review over? 🙏 |
ax3l
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does what the title says. Note that the RealVect already does this.