pytest: Temporary Working Directory #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests can generate temporary output and directories, which might clash and/or need cleaning between tests. This changes the current working directory to a unique directory per test.
sayerhs
reviewed
Aug 28, 2023
tests/conftest.py
Outdated
Comment on lines
38
to
39
| yield | ||
| amr.finalize() |
There was a problem hiding this comment.
Recommend that these two lines are also inside the with block
There was a problem hiding this comment.
I was googling about with context and yield combinations and got nervous about what I saw 😅
sayerhs
approved these changes
Aug 28, 2023
ax3l
commented
Aug 29, 2023
|
Hm, this actually fails my tests in ECP-WarpX/impactx#424 ... maybe because it works now (and cannot find input files)? |
What is the error? How are you creating the input files? |
Not yet used, can be used in test files as ```py from conftest import basepath ```
|
Ah, now managed to pass their path before going into the per-test directory :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests can generate temporary output and directories, which might clash and/or need cleaning between tests.
This changes the current working directory to a unique directory per test.