Fortran BoxArray: Add nboxes function returning the number of boxes. #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the function returns the total number of boxes including ones not owned by the MPI process calling the function.
asalmgren
approved these changes
Aug 19, 2024
|
Great, thanks for the blazing fast turn-around! Quick question though - I see that you have the number of boxes returned as a long/integer(amrex_long), but the get_box function takes in an integer. That seems inconsistent, and may need to be changed so that both procedures use long and integer(amrex_long)? |
|
Yes, you are right that the two are not consistent. Unfortunately the inconsistency has already existed in the C++ code. |
|
Fair enough - thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the function returns the total number of boxes including ones not owned by the MPI process calling the function.