Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLEBNodeFDLaplacian: Regression #4085

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 16, 2024

Summary

Fix copy-paste regression from #4083

Additional background

#4083 (comment)

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Fix copy-paste regression from AMReX-Codes#4083
@WeiqunZhang
Copy link
Member

Shoot. I blame clang-tidy for this bug. I wrote perfectly fine code. But clang-tidy false accused me over and over. So I had to change a couple of times to make it happy.

@WeiqunZhang WeiqunZhang enabled auto-merge (squash) August 16, 2024 00:51
@WeiqunZhang WeiqunZhang merged commit d9919c9 into AMReX-Codes:development Aug 16, 2024
71 of 72 checks passed
@ax3l ax3l deleted the fix-eb-regression branch August 16, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants