Pure SoA: NextID as Long
#3772
Merged
Pure SoA: NextID as Long
#3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
fix-nextid-long
branch
from
13604d1
to
8aa5389
Compare
This is a leftover from an earlier implementation of pure SoA. Our 39bit particle ids must be stored in an `amrex::Long`. An `int` will crop them to 32bit range, which we quickly run out from.
ax3l
force-pushed
the
fix-nextid-long
branch
from
8aa5389
to
1fc2357
Compare
2 tasks
atmyers
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a leftover from an earlier implementation of pure SoA. Our 39bit particle ids must be stored in an
amrex::Long. Anintwill crop them to 32bit range, which we quickly run out from.Additional background
Related to #3569 / #3585.
Checklist
The proposed changes: