Bins: Index Type int
#3684
Merged
Bins: Index Type int
#3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
bins-int
branch
2 times, most recently
from
202255a
to
3dd5932
Compare
|
Hi @ax3l - this looks good to me - could you fix the conflicts, then we'll merge? |
For performance reasons, `int` are better index types since they do not have over/underflow checks and thus vectorize better. Also, I see narrowing warnings casting from `int` to AMReX' `unsigned int` in WarpX.
|
Let us merge this after I will post an update to WarpX with the weekly update: ECP-WarpX/WarpX#5102 |
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Jul 30, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
1 task
atmyers
approved these changes
Aug 6, 2024
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 11, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 12, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 14, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 14, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
4 tasks
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 15, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 16, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Aug 16, 2024
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
ax3l
added a commit
to ECP-WarpX/WarpX
that referenced
this pull request
Aug 16, 2024
* AMReX: Weekly Update * pyAMReX: Weekly Update * AMReX: `int` Index Type for Bins Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes. * `ref_ratios.size()` -> `max_level` Address a breaking change in AMReX. * Update ThetaImplicitPicard_1d,SemiImplicitPicard_1d AMReX default change: `amr.max_grid_size` is 64 from 32 now. Since these tests are run with 2 MPI ranks, ensure we have at least one box per MPI rank. Instead of 20=40/2 set again to 32, to keep checksums the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For performance reasons,
int/longare better index types since they do not have over/underflow checks and thus vectorize better.Also, I see narrowing warnings casting from
intto AMReX'unsigned intin WarpX.Additional background
Seen with clang-tidy in ECP-WarpX/WarpX#3850
Checklist
The proposed changes: