solve_cg: consistent RT casting #3638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eebasso
commented
Dec 6, 2023
| { | ||
| ret = 1; break; | ||
| } | ||
| const RT alpha = rho/pw; |
There was a problem hiding this comment.
This restructuring of the divide by zero check allows alpha to be defined and declared in one line as a const RT instead of the current RT declaration.
|
This is a small change for the sake of change; in the best interest of the developers' time we would like contributors to focus their efforts on fixing erroneous code (aka bugs) and contributing new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes sure that every instance in
solve_cgof setting an RT variable to 0 or checking if it is equal to 0 uses the explicit RT(0.0) cast.Additional background
This is similar to the PR made for
solve_bicgstab.