ParmParse: Option to disable multi-line support #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
parmparse_multiline
branch
2 times, most recently
from
4b7b262
to
6216179
Compare
By default, ParmParse supports multi-line values. For example,
```
plot_vars = dens vx vy vx
energy entropy
```
This can be disabled by calling setMultiLineSupport(false) before
amrex::Initialize(). This can avoid errors in inputs like,
```
algo.current_deposition = direct
# Enable galilean
psatd.use_default_v_galilean # Unfortunately we forgot = 1
```
With multi-line support, this is unfortunately equivalent to
```
algo.current_deposition = direct psatd.use_default_v_galilean
```
With multi-line support disabled, it will abort. Note that even
after multi-line support is disabled, one is still allowed to have
```
f = "x + y
+ sin(z)"
```
because here what's inside the pair of double quotes is considered a single
string.
WeiqunZhang
force-pushed
the
parmparse_multiline
branch
from
6216179
to
412eb46
Compare
atmyers
approved these changes
Jul 20, 2023
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 21, 2023
In AMReX-Codes#3433, we added an option to disable multi-line support to avoid certain types of errors. Since multi-line support seems to be desirable feature, we add a new feature that uses `\` as line continuation. To avoid confusion, we have decided to stop supporting the old style of multi-line values and make it a runtime error. Hopefully it does not cause too much trouble for users.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 21, 2023
In AMReX-Codes#3433, we added an option to disable multi-line support to avoid certain types of errors. Since multi-line support seems to be desirable feature, we add a new feature that uses `\` as line continuation. To avoid confusion, we have decided to stop supporting the old style of multi-line values and make it a runtime error. Hopefully it does not cause too much trouble for users.
WeiqunZhang
added a commit
that referenced
this pull request
Jul 21, 2023
In #3433, we added an option to disable multi-line support to avoid certain types of errors. Since multi-line support seems to be desirable feature, we add a new feature that uses `\` as line continuation. To avoid confusion, we have decided to stop supporting the old style of multi-line values and make it a runtime error. Hopefully it does not cause too much trouble for users.
mirenradia
added a commit
to GRTLCollaboration/GRTeclyn
that referenced
this pull request
Aug 4, 2023
Following AMReX-Codes/amrex#3433 and AMReX-Codes/amrex#3437, line continuation is only supported with a '\' character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, ParmParse supports multi-line values. For example,
This can be disabled by calling setMultiLineSupport(false) before amrex::Initialize(). This can avoid errors in inputs like,
With multi-line support, this is unfortunately equivalent to
With multi-line support disabled, it will abort. Note that even after multi-line support is disabled, one is still allowed to have
because here what's inside the pair of double quotes is considered a single string.