cleaning and fixes for PureSoA ParticleTile #3327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
id()
andcpu()
withdecltype(auto)
data
anddataPtr
formArrayOfStructs
(they should have returned ParticleType* but returned the position array of the first particle)packParticleData
andunpackParticleData
for PureSoAgetSuperParticle
and addsetSuperParticle
for PureSoA. Remaining issue: super particle has redundant/unused fields for positions, id and cpuConstParticleTileData
for PureSoAgetParticleTileData
inParticleTile::id()
etc. as this could be very slow if used in a for loopgetParticleTileData()
won't allocate memory if no runtime components are usedAdditional background
Follow-up to #2878.
Checklist
The proposed changes: