Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RealVect version of pos() for pure SoA #3283

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Apr 27, 2023

Follow-up to #2878.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from ax3l April 27, 2023 17:10
@atmyers atmyers mentioned this pull request Apr 27, 2023
5 tasks
@ax3l ax3l self-assigned this Apr 27, 2023
@ax3l ax3l added the bug label Apr 27, 2023
@ax3l ax3l merged commit 8d6ef28 into AMReX-Codes:development Apr 27, 2023
guj pushed a commit to guj/amrex that referenced this pull request Jul 13, 2023
The proposed changes:
- [x] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants