-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use autodiff in templated network rate evaluation #1614
Conversation
b90b3e5
to
6b78dd2
Compare
This wasn't computing any derivatives before.
6b78dd2
to
d4173de
Compare
Timings for
|
do you expect the diffs shown in the test suite? |
No, I don't think the diffs should be that large. I'm even more confused by the diffs with the numerical Jacobian, as that shouldn't be using autodiff at all. |
let me rerun the test |
We can restore these later in a separate PR.
I found a few optimizations I made that were causing the differences with the numerical Jacobian, and I'm now pretty sure the other big diffs are just compounded from the roundoff diffs in the analytical Jacobian. |
The diffs are smaller now.
2b47277
to
3afa5ef
Compare
most test_rhs diffs are now roundoff, except for powerlaw, which is Inf |
This should be ready to merge. The Inf diffs for powerlaw are because we weren't calculating the temperature derivatives at all before. |
No description provided.