Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 2d spherical geometry abort and add some asserts for 2d spherical geometry setup. #2973

Merged
merged 5 commits into from
Oct 7, 2024
Merged

remove 2d spherical geometry abort and add some asserts for 2d spherical geometry setup. #2973

merged 5 commits into from
Oct 7, 2024

Conversation

zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented Oct 7, 2024

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3 zhichen3 marked this pull request as ready for review October 7, 2024 19:43
@zhichen3 zhichen3 requested a review from zingale October 7, 2024 20:04
@zingale zingale merged commit 68c1a15 into AMReX-Astro:development Oct 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale Awaiting requested review from zingale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhichen3 @zingale