update the shock detection algorithm for r-theta #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhichen3
reviewed
Sep 17, 2024
Source/hydro/advection_util.cpp
Outdated
| // balances that is not available to make a shock. | ||
| // balances that is not available to make a shock. We compute this | ||
| // as: | ||
| // P'_{i+1} = P_{i+1} - [ P_i - \int_{x_i}^{x_{i+1}} rho g dx |
There was a problem hiding this comment.
extra [ in comment here?
There was a problem hiding this comment.
I was missing the close ]. Fixed.
There was a problem hiding this comment.
I've made the comment clearer
zhichen3
reviewed
Sep 18, 2024
Source/hydro/advection_util.cpp
Outdated
| // balances that is not available to make a shock. | ||
| // balances that is not available to make a shock. We compute this | ||
| // as: | ||
| // P'_{i+1} = P_{i+1} - [ P_i - \int_{x_i}^{x_{i+1}} rho g dx ] |
There was a problem hiding this comment.
wouldn't that make it +rho g dx since there are two minus?
There was a problem hiding this comment.
I've made the comment clearer and fixed the sign
zhichen3
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate