Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subchandra: bump react_rho_min up to 100 #2748

Merged
merged 1 commit into from
Feb 10, 2024
Merged

subchandra: bump react_rho_min up to 100 #2748

merged 1 commit into from
Feb 10, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 9, 2024

this seems to do better when the atmosphere gets poofy

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
subchandra: bump react_rho_min up to 100
4e2ee27 
this seems to do better when the atmosphere gets poofy
@zingale zingale merged commit 744521b into AMReX-Astro:development Feb 10, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz