Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap the order of Poisson and the first burn for Strang #2726

Merged
merged 5 commits into from
Apr 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Source/sources/Castro_sources.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,15 @@ Castro::pre_advance_operators (Real time, Real dt)

advance_status status {};

// If we are using gravity, solve for the potential and
// gravitational field. note: since reactions don't change
// density, we can do this before or after the burn.

#ifdef GRAVITY
construct_old_gravity(time);
#endif


// If we are Strang splitting the reactions, do the old-time contribution now.

#ifndef TRUE_SDC
Expand All @@ -541,11 +550,6 @@ Castro::pre_advance_operators (Real time, Real dt)
#endif
#endif

// If we are using gravity, solve for the potential and gravitational field.

#ifdef GRAVITY
construct_old_gravity(time);
#endif

// Initialize the new-time data. This copy needs to come after all Strang-split operators.

Expand Down