Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some nse_test cleaning #2653

Merged
merged 6 commits into from
Feb 19, 2024
Merged

some nse_test cleaning #2653

merged 6 commits into from
Feb 19, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Nov 18, 2023 •
edited
Loading

quiet clang-tidy warnings
redirect convergence output into files
this also makes it use simplified-SDC by default

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale merged commit 56d243e into AMReX-Astro:development Feb 19, 2024
20 checks passed
@zingale zingale deleted the nse_test_cleaning branch February 19, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @zhichen3