Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove aux_names vector #2539

Merged
merged 1 commit into from
Aug 11, 2023
Merged

remove aux_names vector #2539

merged 1 commit into from
Aug 11, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Aug 10, 2023

this seems to be a holdover from when we copied things from Fortran but we can access the names directly from network_properties.H

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
remove aux_names vector
5cd8934 
this seems to be a holdover from when we copied things from Fortran
but we can access the names directly from network_properties.H
@zingale zingale merged commit ba9dfc2 into AMReX-Astro:development Aug 11, 2023
17 checks passed
@zingale zingale deleted the remove_aux_names branch August 11, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz