On burn failure, return immediately before clean_state

Source/reactions/Castro_react.cpp

@@ -17,15 +17,25 @@ Castro::do_old_reactions (Real time, Real dt)
  amrex::ignore_unused(time);
  amrex::ignore_unused(dt);
 
- bool burn_success = true;
+ advance_status status {};
 
 #ifndef SIMPLIFIED_SDC
+ bool burn_success = true;
+
  MultiFab& R_old = get_old_data(Reactions_Type);
  MultiFab& R_new = get_new_data(Reactions_Type);
 
  if (time_integration_method != SimplifiedSpectralDeferredCorrections) {
  // The result of the reactions is added directly to Sborder.
  burn_success = react_state(Sborder, R_old, time, 0.5 * dt, 0);
+
+ if (!burn_success) {
+ status.success = false;
+ status.reason = "burn unsuccessful";
+
+ return status;
+ }
+
  clean_state(
 #ifdef MHD
  Bx_old_tmp, By_old_tmp, Bz_old_tmp,
@@ -36,13 +46,6 @@ Castro::do_old_reactions (Real time, Real dt)
  }
 #endif
 
- advance_status status {};
-
- if (!burn_success) {
- status.success = false;
- status.reason = "burn unsuccessful";
- }
-
  return status;
 }
 
@@ -52,6 +55,8 @@ Castro::do_new_reactions (Real time, Real dt)
  amrex::ignore_unused(time);
  amrex::ignore_unused(dt);
 
+ advance_status status {};
+
  bool burn_success = true;
 
  MultiFab& R_new = get_new_data(Reactions_Type);
@@ -68,6 +73,13 @@ Castro::do_new_reactions (Real time, Real dt)
 
  burn_success = react_state(time, dt);
 
+ if (!burn_success) {
+ status.success = false;
+ status.reason = "burn unsuccessful";
+
+ return status;
+ }
+
  clean_state(S_new, time + dt, S_new.nGrow());
 
  // Check for NaN's.
@@ -94,6 +106,14 @@ Castro::do_new_reactions (Real time, Real dt)
  if (time_integration_method != SimplifiedSpectralDeferredCorrections) {
 
  burn_success = react_state(S_new, R_new, time - 0.5 * dt, 0.5 * dt, 1);
+
+ if (!burn_success) {
+ status.success = false;
+ status.reason = "burn unsuccessful";
+
+ return status;
+ }
+
  clean_state(
 #ifdef MHD
  Bx_new, By_new, Bz_new,
@@ -104,15 +124,7 @@ Castro::do_new_reactions (Real time, Real dt)
 
 #endif // SIMPLIFIED_SDC
 
- advance_status status {};
-
- if (!burn_success) {
- status.success = false;
- status.reason = "burn unsuccessful";
- }
-
  return status;
-
 }
 
 // Strang version