Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module version #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

bogdan556
Copy link

Changes

Allow the caller of the module to upgrade/downgrade version of the provider without needing a new release of the module.

@hbjydev
Copy link
Member

hbjydev commented Feb 27, 2024

Sorry, missed this PR -- can I ask what the motivation for it is? And have you checked if the changes here are backwards-compatible or not?

@hbjydev
Copy link
Member

hbjydev commented Feb 27, 2024

I think part of me would rather just bump the provider version in the module so it remains explicit, because we're using implicit versions as part of some of our automation at ALT-F4.

@bogdan556
Copy link
Author

This would allow anyone who wants to reutilize this module to set the provider version for github at the top level, right now being a hardcoded fixed version deep in the module logic, it's very limited and always would require a new release of the module.
Thus the module defining a version constraint, or version interval that it supports, you can specify explicitly the version for the
given provider at the top level of the project.

For reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants