Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Better job blacklisting with regex #743

Merged

Conversation

GuilhermeRameh
Copy link

Solves #667

What i added:

  • import of re library for regex
  • added regex pattern generation on "set_parameters" function to run it only at the start
  • added function "generate_regex_patterns" for the generation itself, based on the blacklist parameters already defined before
  • modified "is_blacklisted" function to use re library and regex patterns created

Local tests were successfull:
image

If there is anything else i need to add, im happy to work on it!

Copy link
Collaborator

@surapuramakhil surapuramakhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @GuilhermeRameh

src/ai_hawk/job_manager.py Outdated Show resolved Hide resolved
src/ai_hawk/job_manager.py Outdated Show resolved Hide resolved
@GuilhermeRameh
Copy link
Author

Changes added!

@surapuramakhil surapuramakhil merged commit f5e6ffc into AIHawk-app:release/v11.15.2024 Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants