Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lag shift trim (discard) function #20

Closed
wants to merge 36 commits into from

Conversation

geek-yang
Copy link
Member

@geek-yang geek-yang commented Jun 7, 2022

As a user, I want to obtain the intervals with preferred time lag for my target period. The rest will be discarded.

This PR closes issue #19 .

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@geek-yang
Copy link
Member Author

This PR involves too much old design which has been replaced by new implementations. In order to keep the codebase clean, I will close this PR and implement the discard function based on the latest codebase.

@geek-yang geek-yang closed this Jun 16, 2022
@jannesvaningen jannesvaningen deleted the implement_lag_shift_trim branch October 26, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant