Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the lag shifting (discard) method #19

Closed
geek-yang opened this issue Jun 6, 2022 · 1 comment
Closed

Implementing the lag shifting (discard) method #19

geek-yang opened this issue Jun 6, 2022 · 1 comment

Comments

@geek-yang
Copy link
Member

The lag shifting method will be implemented in the time.py module. When initializing the AdventCalendar object, a calendar with counting backward time intervals is created. The user need to provide the target time range and the maximum lag value to finalize the calendar by "trimming" those intervals.

For reference, the relevant legacy codes are:
https://github.com/AI4S2S/proto/blob/0dd397f6101573544f10a55a4205e037e69acdfe/forecasting/func_models.py#L153

Our previous discussion about the design of this module can be found in AI4S2S/proto#3.

@geek-yang geek-yang changed the title Implementing the lag shifting method Implementing the lag shifting (discard) method Jun 10, 2022
@geek-yang
Copy link
Member Author

This issue is not valid anymore based on the current design. It will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant