Skip to content

Commit

Permalink
Fix parsing and roundtrip (finos#2630)
Browse files Browse the repository at this point in the history
* add serviceloader file

* fix file path

* Refactor ownership

* Refactor ownership

* Refactor ownership

* Fix tests

* Fix tests

* uplift grammar

* uplift grammar

* fix tests

* fix tests

* fix tests

* Add properties to result

* Add properties to result

* fix style

* fix style

* remove property

* move property

* Cleanup artifact generation

* fix style

* Fix dependencies

* Cleanup grammar

* Change artifact generation content

* add quotes in transformer

* fix parsing
  • Loading branch information
Yasirmod17 authored Feb 14, 2024
1 parent ea40870 commit ce30fa9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ private HostedService visitHostedService(HostedServiceParserGrammar.ServiceConte
else
{
HostedServiceParserGrammar.DeploymentContext deploymentOwnerContext = ownerContext.deployment();
hostedService.ownership = new DeploymentOwner((deploymentOwnerContext.STRING().getText()));
hostedService.ownership = new DeploymentOwner(PureGrammarParserUtility.fromGrammarString(deploymentOwnerContext.STRING().getText(), true));
}
}
HostedServiceParserGrammar.ServiceDocumentationContext descriptionContext = PureGrammarParserUtility.validateAndExtractOptionalField(ctx.serviceDocumentation(), "documentation", hostedService.sourceInformation);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private static String renderServiceOwner(Ownership owner)
}
else if (owner instanceof DeploymentOwner)
{
return "Deployment { identifier: " + ((DeploymentOwner)owner).id + " };\n";
return "Deployment { identifier: '" + ((DeploymentOwner)owner).id + "' };\n";
}
throw new RuntimeException("Owner type invalid");
}
Expand Down

0 comments on commit ce30fa9

Please sign in to comment.