Implement a barebones v8 executor #744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasikpark
reviewed
Aug 29, 2022
domenukk
reviewed
Aug 30, 2022
the cpuset api is already present in libc...
* add test case minimising stage * general purpose minimiser impl, with fuzzer example * reorganise, document, and other cleanup * correct python API return value * correct some docs * nit: versioning in fuzzers * ise -> ize
* initial try * correct case where cull attempts to fetch non-existent corpus entries * various on_remove, on_replace implementations * ise -> ize (consistency), use TestcaseScore instead of rolling our own * oops, feature gate * documentation! * link c++ * doc-nit: correction in opt explanation don't write documentation at 0300 * better linking
* Skippable stage, generator wrapper for Grimoire * more fancy wrapper
* Adding support for with_name() * Adding with_name() function description
supporting most of linux sched api here.
jasikpark
reviewed
Aug 30, 2022
| // RNG | ||
| StdRand::with_seed(current_nanos()), | ||
| // Corpus that will be evolved, we keep it in memory for performance | ||
| OnDiskCorpus::new(&corpus_dir).unwrap(), |
There was a problem hiding this comment.
No, that'd need a CachedOnDiskCorpus or a InMemoryCorpus
There was a problem hiding this comment.
So the comment is outdated here
Mrmaxmeier
reviewed
Oct 16, 2022
| [dependencies] | ||
| ahash = { version = "0.7", features = ["compile-time-rng"] } | ||
| deno_ast = { version = "0.17.0", features = ["transpiling"] } | ||
| # fetch deno directly because of git deps; cannot use local submodule due to workspacing |
There was a problem hiding this comment.
Does this comment still apply? I've tried switching to deno from crates.io (here) and that seems to work fine.
|
Cool stuff! Feel free to |
|
What's missing for this PR then? |
|
This needs a rewrite following #913 since we can handle async much better in that context. Closing for now and using as a reference in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related: #742
I'm still working on getting coverage feedback via: https://v8.dev/docs/inspector
However, wanted to share this as a demonstration that it is indeed possible.