Added expect error message to TimeFeedback where there used to be an unwrap #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you run cargo fmt? |
domenukk
reviewed
Dec 18, 2024
| @@ -940,7 +940,7 @@ where | |||
| observers: &OT, | |||
| testcase: &mut Testcase<I>, | |||
| ) -> Result<(), Error> { | |||
| let observer = observers.get(&self.observer_handle).unwrap(); | |||
| let observer = observers.get(&self.observer_handle).expect("Observer referenced by TimeFeedback is not found in observers given to the fuzzer"); | |||
There was a problem hiding this comment.
I think the right way here would be to return Err(Error::illegal_state("Observer referenced by TimeFeedback is not found in observers given to the fuzzer"))
There was a problem hiding this comment.
And anyway this should never happen, how did you reach this state?
There was a problem hiding this comment.
I reached it because I didn't give the fuzzer all my observers. I got confused when it just hit the unwrap, so then I made the PR.
|
Can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this unwrap while writing a fuzzer. If the observer referenced by a TimeFeedback isn't in the fuzzer, then this unwrap is triggered with no helpful error message. I put down
Observer referenced by TimeFeedback is not found in observers given to the fuzzeras the error message when this is hit.