Add optional feature to share objectives between nodes #2754
Conversation
|
Do tell me if I have overlooked anything. Also, is this okay as a compile-time option? |
yeah |
|
Does LibAFL have a preferred way to tackle conditional trait bounds based on compile-time features? I am having to add optional trait bounds by dividing implementations based on features, and is causing massive code duplication |
|
The implementation of |
|
@tokatoka is this issue fixed? Should I stop working on this issue? |
|
no i closed because you have this PR |
|
I suggest we leave issues open until they are actually fixed in |
|
Any idea why |
Seems like the |
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "share_objectives")] |
There was a problem hiding this comment.
do you need to do like this?
you can just add to the previous impl LlmpEventConverter
There was a problem hiding this comment.
I would even prefer to do this with a runtime flag, the overhead is minimal since there are not too many objectives found. Then the code is cleaner I think(?)
|
Should I try implementing this in some other way? |
fixes issue #1917