Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Pass tests #38

Merged
merged 48 commits into from
Oct 18, 2023
Merged

WIP: Pass tests #38

merged 48 commits into from
Oct 18, 2023

Commits on Sep 28, 2023

  1. Get rid of a Kokkos warning about All_t

    Ben Prather committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c234337 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f723196 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Parthenon bump, callbacks

    Rename two very Athena-sounding callbacks more inline, add 'PostExecute'
    Ben Prather committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b99b160 View commit details
    Browse the repository at this point in the history
  2. Remove unused reducers, add comments

    Ben Prather committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c1c940e View commit details
    Browse the repository at this point in the history
  3. Organize prob/, make problems request B fields

    The idea is to have every problem capable of either B field transport,
    but this requires defining a function for A or B rather than setting it,
    since you don't know where it lives.
    This solution is not ideal, but I think it'll work okay
    Ben Prather committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    17b5b81 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'kharma-next' into fix/pass-tests

    Ben Prather committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    96c8792 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Reorganize parameter files

    This finally organizes the different parameter files into folders.
    Plenty of parfiles fit more than one category, feel free to move them.
    
    Better parfile documentation is planned as we bring up the rest of
    the tests.
    Ben Prather committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    ca3b994 View commit details
    Browse the repository at this point in the history
  2. Better boundaries, options

    * Try to make block and domain boundaries clear but
    flexible. Now supports, between blocks:
    sync cons
    sync prims
    sync prims (but under the hood sync cons for AMR)
    and for domain boundaries:
    prims are marked sync ->
        PtoU everything
    cons,GRHD prims are marked sync ->
        UtoP except PtoU on MHD
    cons,GRHD prims are marked sync ->
        UtoP everything
    * Dirichlet boundary fixes
    * More options to try inadvisable things on boundaries,
        & to record exactly what was applied
    * Drivers now have a type
    * Put in structure for limiting MPI sync vars
    * Clearly deprecate B_CD
    * Rename B_Cleanup -> general StartupOnly flag
    * Don't allocate in current calc
    Ben Prather committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    0e416cd View commit details
    Browse the repository at this point in the history
  3. Problem init & tests (round 1)

    This moves the rest of the problem initializations to using the
    unified field init.  It also fixes some issues starting up problems when
    magnetic field has been added, which may have affected the
    starting internal energy of tori at times in the past (will check).
    
    It also moves (restores) a few very specific/brittle parameter files
    into their specific test dirs, rather than global 'pars' dir.
    Ben Prather committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    efcf77e View commit details
    Browse the repository at this point in the history
  4. Fix propagating B3 in 2D with face CT, pass mhdmodes

    Ben Prather committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1303b9b View commit details
    Browse the repository at this point in the history
  5. Pass bondi problem

    Fix run script, fix enabling flag_verbose in imex
    Support running in bare KS coordinates via new trivial transform
    (needed the check a little looser, turns out KS are not good coords)
    Ben Prather committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    c817f19 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Pass aniso_conduction, emhdmodes

    * Restores EMHD terms to stress-energy tensor
        (no, I do not remember why they were removed in this branch...)
    * Run script touch-ups for bondi_viscous but dP still not converging
    bprather committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    c5d183f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4229a12 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Test updates & restarting

    Restarts now record cons by default, GRMHD prims only
    Restarting is now binary-similar @5 steps
    Also add back strict 'set -euo pipefail' to kill tests on nonzero
    returns, and fix some more test scripts
    Ben Prather committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c4588cf View commit details
    Browse the repository at this point in the history
  2. Fix B_Cleanup

    As with the rest of KHARMA, B-field cleaning was ignoring the divergence
    on corners which fell on the the polar faces.  This is because BiCGStab
    wasn't applying any physical boundary conditions on phi during solving.
    
    The easy way to get correct boundary conditions was to declare
    the scalar field and RHS to be explicitly defined at corners/nodes, and
    let Parthenon apply the default bounds for that case (as well as
    applying our own boundaries to the intermediate dB when calculating the
    Laplacian)
    
    With the new boundaries, the "physical" domain for phi is now larger,
    so bicgstab_solver had to be heavily modified. Since it's no longer
    going to be upstreamed, I just forked it.
    Ben Prather committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    802bdb2 View commit details
    Browse the repository at this point in the history
  3. Fix some EMHD stuff

    Not all flag names were updated "EMHD"->"EMHDVar", I suspect a merge
    somewhere regressed that.
    Also fix some more scripts
    Ben Prather committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    26cf7f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. CI: try to fix CPU build

    Ben Prather committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    61de2e2 View commit details
    Browse the repository at this point in the history
  2. CI+tests stuff

    Ben Prather committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0a6585f View commit details
    Browse the repository at this point in the history
  3. CI: fix pyharm via mamba

    Ben Prather committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c42db13 View commit details
    Browse the repository at this point in the history
  4. CI: pyharm install fixes

    Ben Prather committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    184f65b View commit details
    Browse the repository at this point in the history
  5. CI again

    Ben Prather committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    15b4026 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Rename AddMPIBoundarySync to AddBoundarySync

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    dd1a566 View commit details
    Browse the repository at this point in the history
  2. Get viscosity-only EMHD working again

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8ff9383 View commit details
    Browse the repository at this point in the history
  3. Bump Kokkos to fix CUDA bug

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9b06281 View commit details
    Browse the repository at this point in the history
  4. Bunch of test script fixes

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    ea701f9 View commit details
    Browse the repository at this point in the history
  5. Add some tests that are ready, fix artifacts

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    de75557 View commit details
    Browse the repository at this point in the history
  6. CI fix

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    ff49d37 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a8b177d View commit details
    Browse the repository at this point in the history
  8. Tone down CI core usage a touch, use abs paths

    Ben Prather committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    aea831f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Fix the boundaries of EMHD problems

    All MHD variables in bondi_viscous now converge as expected, and
    boundaries are applied to dP as expected. Source term seems to be
    much, much too large for some reason.
    
    Also Vbump Kokkos to fix a CUDA segfault (again?)
    Ben Prather committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a3f43eb View commit details
    Browse the repository at this point in the history
  2. Fix compile w/new Flux_CT B flags

    Ben Prather committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2a99504 View commit details
    Browse the repository at this point in the history
  3. CI: tar fixes

    Ben Prather committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0e363b2 View commit details
    Browse the repository at this point in the history
  4. CI: more mamba installation

    Ben Prather committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5619ebb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b92750d View commit details
    Browse the repository at this point in the history
  6. Fix Noh test by parsing e- gamma correctly in checker

    Ben Prather committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b62fd11 View commit details
    Browse the repository at this point in the history
  7. CI: sigh

    Ben Prather committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e4747eb View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Get rid of sync_prims

    Supporting exchanging primitive vars only for ImEx driver in non-AMR
    had become a source of bugs, incl. last commit.  Fix by simplifying.
    
    ImEx driver needs to be able to sync conserved variables anyway for AMR,
    so better to keep the same codepath even at the cost of the occasional
    UtoP/PtoU call.
    Ben Prather committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d7d61e7 View commit details
    Browse the repository at this point in the history
  2. Repair some tests for always syncing cons

    These bugs would have appeared more inscrutably when we ran w/AMR anyway
    Ben Prather committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f1e1cb9 View commit details
    Browse the repository at this point in the history
  3. Test fixes, but not the important ones

    Ben Prather committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    868b033 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76d346e View commit details
    Browse the repository at this point in the history
  5. Revert "Get rid of sync_prims"

    This reverts commit d7d61e7.
    Ben Prather committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    20c2a11 View commit details
    Browse the repository at this point in the history
  6. Sync primitive variables if they're fundamental

    A few commits back I removed sync_prims, reasoning conserved variables
    should be prolongated/restricted, and could always be recovered from
    each other.  Both points were wrong: primitive vars can be prolongated
    and restricted on boundaries fine, though the latter is not ideal. And,
    in EMHD, it is not straightforward to recover P from U, as this is
    normally done inline with the computation of the next step's state.
    
    This commit switches to syncing primitive variables (sync_prims) anytime
    they're fundamental (ImEx and simple drivers, "prims_are_fundamental")
    Note the "conserved" B field is *always* what is sync'd, regardless
    of the other primitive or conserved variables.
    
    It also avoids loading the inverter package if GRMHD is implicitly
    evolved, and expands some computed domains related to B to work
    at the last prolongation operator bug before AMR.
    Ben Prather committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0541185 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Fix the build

    Ben Prather committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4fc472f View commit details
    Browse the repository at this point in the history
  2. Fix floors so we don't need to load Inverter pkg

    Ben Prather committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    218a875 View commit details
    Browse the repository at this point in the history
  3. Viscous Bondi test touchups, prototype SMR test

    Ben Prather committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ac46a45 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Add & repair conducting atmo so it fails properly

    Ben Prather committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f774756 View commit details
    Browse the repository at this point in the history
  2. Converge on last tests

    Viscous Bondi:
    use outflow conditions, solve ODE from outer edge value
    (converges to fixed condition, but not at 2o, probably due to
    limited runtime)
    
    Conducting atmo:
    actually return check result, converge by fixing detection of
    higher-order terms.
    Ben Prather committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5eef03a View commit details
    Browse the repository at this point in the history
  3. Fix viscous Bondi test script for hypothetical case without higher or…

    …der terms
    Ben Prather committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    9750787 View commit details
    Browse the repository at this point in the history