-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Pass tests #38
WIP: Pass tests #38
Commits on Sep 28, 2023
-
Get rid of a Kokkos warning about All_t
Ben Prather committedSep 28, 2023 Configuration menu - View commit details
-
Copy full SHA for c234337 - Browse repository at this point
Copy the full SHA c234337View commit details -
Compile fixes for using custom linker & for personal machines
Ben Prather committedSep 28, 2023 Configuration menu - View commit details
-
Copy full SHA for f723196 - Browse repository at this point
Copy the full SHA f723196View commit details
Commits on Sep 29, 2023
-
Rename two very Athena-sounding callbacks more inline, add 'PostExecute'
Ben Prather committedSep 29, 2023 Configuration menu - View commit details
-
Copy full SHA for b99b160 - Browse repository at this point
Copy the full SHA b99b160View commit details -
Remove unused reducers, add comments
Ben Prather committedSep 29, 2023 Configuration menu - View commit details
-
Copy full SHA for c1c940e - Browse repository at this point
Copy the full SHA c1c940eView commit details -
Organize prob/, make problems request B fields
The idea is to have every problem capable of either B field transport, but this requires defining a function for A or B rather than setting it, since you don't know where it lives. This solution is not ideal, but I think it'll work okay
Ben Prather committedSep 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 17b5b81 - Browse repository at this point
Copy the full SHA 17b5b81View commit details -
Merge branch 'kharma-next' into fix/pass-tests
Ben Prather committedSep 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 96c8792 - Browse repository at this point
Copy the full SHA 96c8792View commit details
Commits on Oct 3, 2023
-
This finally organizes the different parameter files into folders. Plenty of parfiles fit more than one category, feel free to move them. Better parfile documentation is planned as we bring up the rest of the tests.
Ben Prather committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for ca3b994 - Browse repository at this point
Copy the full SHA ca3b994View commit details -
* Try to make block and domain boundaries clear but flexible. Now supports, between blocks: sync cons sync prims sync prims (but under the hood sync cons for AMR) and for domain boundaries: prims are marked sync -> PtoU everything cons,GRHD prims are marked sync -> UtoP except PtoU on MHD cons,GRHD prims are marked sync -> UtoP everything * Dirichlet boundary fixes * More options to try inadvisable things on boundaries, & to record exactly what was applied * Drivers now have a type * Put in structure for limiting MPI sync vars * Clearly deprecate B_CD * Rename B_Cleanup -> general StartupOnly flag * Don't allocate in current calc
Ben Prather committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 0e416cd - Browse repository at this point
Copy the full SHA 0e416cdView commit details -
Problem init & tests (round 1)
This moves the rest of the problem initializations to using the unified field init. It also fixes some issues starting up problems when magnetic field has been added, which may have affected the starting internal energy of tori at times in the past (will check). It also moves (restores) a few very specific/brittle parameter files into their specific test dirs, rather than global 'pars' dir.
Ben Prather committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for efcf77e - Browse repository at this point
Copy the full SHA efcf77eView commit details -
Fix propagating B3 in 2D with face CT, pass mhdmodes
Ben Prather committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 1303b9b - Browse repository at this point
Copy the full SHA 1303b9bView commit details -
Fix run script, fix enabling flag_verbose in imex Support running in bare KS coordinates via new trivial transform (needed the check a little looser, turns out KS are not good coords)
Ben Prather committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for c817f19 - Browse repository at this point
Copy the full SHA c817f19View commit details
Commits on Oct 4, 2023
-
Pass aniso_conduction, emhdmodes
* Restores EMHD terms to stress-energy tensor (no, I do not remember why they were removed in this branch...) * Run script touch-ups for bondi_viscous but dP still not converging
Configuration menu - View commit details
-
Copy full SHA for c5d183f - Browse repository at this point
Copy the full SHA c5d183fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4229a12 - Browse repository at this point
Copy the full SHA 4229a12View commit details
Commits on Oct 5, 2023
-
Restarts now record cons by default, GRMHD prims only Restarting is now binary-similar @5 steps Also add back strict 'set -euo pipefail' to kill tests on nonzero returns, and fix some more test scripts
Ben Prather committedOct 5, 2023 Configuration menu - View commit details
-
Copy full SHA for c4588cf - Browse repository at this point
Copy the full SHA c4588cfView commit details -
As with the rest of KHARMA, B-field cleaning was ignoring the divergence on corners which fell on the the polar faces. This is because BiCGStab wasn't applying any physical boundary conditions on phi during solving. The easy way to get correct boundary conditions was to declare the scalar field and RHS to be explicitly defined at corners/nodes, and let Parthenon apply the default bounds for that case (as well as applying our own boundaries to the intermediate dB when calculating the Laplacian) With the new boundaries, the "physical" domain for phi is now larger, so bicgstab_solver had to be heavily modified. Since it's no longer going to be upstreamed, I just forked it.
Ben Prather committedOct 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 802bdb2 - Browse repository at this point
Copy the full SHA 802bdb2View commit details -
Not all flag names were updated "EMHD"->"EMHDVar", I suspect a merge somewhere regressed that. Also fix some more scripts
Ben Prather committedOct 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 26cf7f1 - Browse repository at this point
Copy the full SHA 26cf7f1View commit details
Commits on Oct 6, 2023
-
Ben Prather committed
Oct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 61de2e2 - Browse repository at this point
Copy the full SHA 61de2e2View commit details -
Ben Prather committed
Oct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 0a6585f - Browse repository at this point
Copy the full SHA 0a6585fView commit details -
Ben Prather committed
Oct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for c42db13 - Browse repository at this point
Copy the full SHA c42db13View commit details -
Ben Prather committed
Oct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 184f65b - Browse repository at this point
Copy the full SHA 184f65bView commit details -
Ben Prather committed
Oct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 15b4026 - Browse repository at this point
Copy the full SHA 15b4026View commit details
Commits on Oct 7, 2023
-
Rename AddMPIBoundarySync to AddBoundarySync
Ben Prather committedOct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for dd1a566 - Browse repository at this point
Copy the full SHA dd1a566View commit details -
Get viscosity-only EMHD working again
Ben Prather committedOct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 8ff9383 - Browse repository at this point
Copy the full SHA 8ff9383View commit details -
Ben Prather committed
Oct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 9b06281 - Browse repository at this point
Copy the full SHA 9b06281View commit details -
Ben Prather committed
Oct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for ea701f9 - Browse repository at this point
Copy the full SHA ea701f9View commit details -
Add some tests that are ready, fix artifacts
Ben Prather committedOct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for de75557 - Browse repository at this point
Copy the full SHA de75557View commit details -
Ben Prather committed
Oct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for ff49d37 - Browse repository at this point
Copy the full SHA ff49d37View commit details -
Pass EMHDModes with Face CT. Clean up some other scripts.
Ben Prather committedOct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for a8b177d - Browse repository at this point
Copy the full SHA a8b177dView commit details -
Tone down CI core usage a touch, use abs paths
Ben Prather committedOct 7, 2023 Configuration menu - View commit details
-
Copy full SHA for aea831f - Browse repository at this point
Copy the full SHA aea831fView commit details
Commits on Oct 9, 2023
-
Fix the boundaries of EMHD problems
All MHD variables in bondi_viscous now converge as expected, and boundaries are applied to dP as expected. Source term seems to be much, much too large for some reason. Also Vbump Kokkos to fix a CUDA segfault (again?)
Ben Prather committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for a3f43eb - Browse repository at this point
Copy the full SHA a3f43ebView commit details -
Fix compile w/new Flux_CT B flags
Ben Prather committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 2a99504 - Browse repository at this point
Copy the full SHA 2a99504View commit details -
Ben Prather committed
Oct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 0e363b2 - Browse repository at this point
Copy the full SHA 0e363b2View commit details -
Ben Prather committed
Oct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 5619ebb - Browse repository at this point
Copy the full SHA 5619ebbView commit details -
CI: sometimes installation scripts are that way for a reason
Ben Prather committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for b92750d - Browse repository at this point
Copy the full SHA b92750dView commit details -
Fix Noh test by parsing e- gamma correctly in checker
Ben Prather committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for b62fd11 - Browse repository at this point
Copy the full SHA b62fd11View commit details -
Ben Prather committed
Oct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for e4747eb - Browse repository at this point
Copy the full SHA e4747ebView commit details
Commits on Oct 10, 2023
-
Supporting exchanging primitive vars only for ImEx driver in non-AMR had become a source of bugs, incl. last commit. Fix by simplifying. ImEx driver needs to be able to sync conserved variables anyway for AMR, so better to keep the same codepath even at the cost of the occasional UtoP/PtoU call.
Ben Prather committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for d7d61e7 - Browse repository at this point
Copy the full SHA d7d61e7View commit details -
Repair some tests for always syncing cons
These bugs would have appeared more inscrutably when we ran w/AMR anyway
Ben Prather committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for f1e1cb9 - Browse repository at this point
Copy the full SHA f1e1cb9View commit details -
Test fixes, but not the important ones
Ben Prather committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 868b033 - Browse repository at this point
Copy the full SHA 868b033View commit details -
Make ordering of GRMHD/EMHD ops consistent, drive-by fixes
Ben Prather committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 76d346e - Browse repository at this point
Copy the full SHA 76d346eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c2a11 - Browse repository at this point
Copy the full SHA 20c2a11View commit details -
Sync primitive variables if they're fundamental
A few commits back I removed sync_prims, reasoning conserved variables should be prolongated/restricted, and could always be recovered from each other. Both points were wrong: primitive vars can be prolongated and restricted on boundaries fine, though the latter is not ideal. And, in EMHD, it is not straightforward to recover P from U, as this is normally done inline with the computation of the next step's state. This commit switches to syncing primitive variables (sync_prims) anytime they're fundamental (ImEx and simple drivers, "prims_are_fundamental") Note the "conserved" B field is *always* what is sync'd, regardless of the other primitive or conserved variables. It also avoids loading the inverter package if GRMHD is implicitly evolved, and expands some computed domains related to B to work at the last prolongation operator bug before AMR.
Ben Prather committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 0541185 - Browse repository at this point
Copy the full SHA 0541185View commit details
Commits on Oct 11, 2023
-
Ben Prather committed
Oct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 4fc472f - Browse repository at this point
Copy the full SHA 4fc472fView commit details -
Fix floors so we don't need to load Inverter pkg
Ben Prather committedOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 218a875 - Browse repository at this point
Copy the full SHA 218a875View commit details -
Viscous Bondi test touchups, prototype SMR test
Ben Prather committedOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for ac46a45 - Browse repository at this point
Copy the full SHA ac46a45View commit details
Commits on Oct 12, 2023
-
Add & repair conducting atmo so it fails properly
Ben Prather committedOct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for f774756 - Browse repository at this point
Copy the full SHA f774756View commit details -
Viscous Bondi: use outflow conditions, solve ODE from outer edge value (converges to fixed condition, but not at 2o, probably due to limited runtime) Conducting atmo: actually return check result, converge by fixing detection of higher-order terms.
Ben Prather committedOct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 5eef03a - Browse repository at this point
Copy the full SHA 5eef03aView commit details -
Fix viscous Bondi test script for hypothetical case without higher or…
…der terms
Ben Prather committedOct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 9750787 - Browse repository at this point
Copy the full SHA 9750787View commit details