WIP: ISMR #120
Open
WIP: ISMR #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared mem contention
…in x3 direction for ISMR
bug fix and extra improvements for ISMR
bug fixed in ISMR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to split the internal mesh refinement pieces out of
feature/multizone_merge. It is still experimental -- in particular, it does not yet recalculate the floors and sound speeds for zones in the de-refinement region, and thus has some trouble integrating difficult states without high floors and other special accommodations. Since the scheme is first-order, it also has a stability factor of 0.5 rather than the usual 1.0 for second-order schemes. However, with a few layers of ISMR the time-step of spherical simulations can be dramatically improved, at the cost of some accuracy right next to the coordinate pole.Please note this is mostly the work of @hyerincho! I'm just backporting it out from the other Multi-zone changes she's made, since it might prove broadly useful. In light of that, if you do make use of this code, please credit her, either via looping her into ensuing projects/papers, or by citing the implementation description to be published this fall.