Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wireless Universal Terminal #88

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

zeng-github01
Copy link
Contributor

@zeng-github01 zeng-github01 commented Oct 19, 2024

resolved #70

@zeng-github01 zeng-github01 changed the title Rework ec2 port Add Wireless Universal Terminal Oct 21, 2024
@zeng-github01 zeng-github01 marked this pull request as draft October 24, 2024 03:55
@zeng-github01 zeng-github01 marked this pull request as ready for review November 3, 2024 07:58
@ChromaPIE
Copy link
Contributor

ChromaPIE commented Nov 18, 2024

you'll have to update AE2FCR in dependencies.gradle btw. 332d525 said it's updating it but it's not actually up there.
Also the latest NAE2 build crashes the game when mekanism energistics, maybe lacks some necessary checks for its presence. i'd be very appreciated if you could fix it

Also, tried it out a little bit, main feature functioning perfectly but:

  • Equippable in bauble slots but no key to open it
  • Does not support Ext. Processing Fluid Pattern Terminal
  • Change texture as the mode switches?
  • Now you toggle modes using sneak RMB but maybe it's better to hold it and scroll the mouse wheel to cycle through the modes back and forth, just like how Nomifactory improves P2P Tunnels: You hold one or a stack in main hand, hold shift (Not sneak but hardcoded to Shift, but you can bind it to sneak or make a new keybind), scroll the wheel, and it changes the type of P2Ps. Or, we can reimplement the Wheel Menu of the goated AE2WT.
  • Suggestion for the tooltips:
    Instead of
    Mode: Item
    Installed:
    Crafting
    Fluid
    Pattern
    ...
    How about:
    Mode:
    [ Crafting ] (Bold? and/or highlight it with a color?)
    Fluid
    Pattern

@zeng-github01
Copy link
Contributor Author

zeng-github01 commented Nov 19, 2024

you'll have to update AE2FCR in dependencies.gradle btw. 332d525 said it's updating it but it's not actually up there.
Also the latest NAE2 build crashes the game when mekanism energistics, maybe lacks some necessary checks for its presence. i'd be very appreciated if you could fix it

Also, tried it out a little bit, main feature functioning perfectly but:

  • Equippable in bauble slots but no key to open it
  • Does not support Ext. Processing Fluid Pattern Terminal
  • Change texture as the mode switches?
  • Now you toggle modes using sneak RMB but maybe it's better to hold it and scroll the mouse wheel to cycle through the modes back and forth, just like how Nomifactory improves P2P Tunnels: You hold one or a stack in main hand, hold shift (Not sneak but hardcoded to Shift, but you can bind it to sneak or make a new keybind), scroll the wheel, and it changes the type of P2Ps. Or, we can reimplement the Wheel Menu of the goated AE2WT.
  • Suggestion for the tooltips:
    Instead of
    Mode: Item
    Installed:
    Crafting
    Fluid
    Pattern
    ...
    How about:
    Mode:
    [ Crafting ] (Bold? and/or highlight it with a color?)
    Fluid
    Pattern

I will consider updating the Tooltip based on your suggestion. To be honest, I am not very satisfied with the current "current mode" identification method.

As for the mode switching update, I don’t know how to implement it yet.

about crashes. AE2FCR can also cause crashes when it is not installed, I'm troubled by this

Regarding the extension terminal, it cannot be realized because there is no wireless terminal. I need to provide it in AE2 first

@ChromaPIE
Copy link
Contributor

@zeng-github01 listen bruv this thing is SO fked up LMAO. you have to fix this ASAP bc it now allows you to get ANY items in game for free long as you have a universal terminal with Pattern and Crafting mode.

to reproduce:

  1. Toggle to Pattern mode, drag and drop anything from JEI to the grid
  2. Switch to Crafting mode, and the ghost item will be actualized
  3. Take it out.

Simple as that.

@zeng-github01
Copy link
Contributor Author

@zeng-github01 listen bruv this thing is SO fked up LMAO. you have to fix this ASAP bc it now allows you to get ANY items in game for free long as you have a universal terminal with Pattern and Crafting mode.

to reproduce:

  1. Toggle to Pattern mode, drag and drop anything from JEI to the grid
  2. Switch to Crafting mode, and the ghost item will be actualized
  3. Take it out.

Simple as that.

This is a compatibility issue. It may be caused by the closeness of Pattern and Crafting's Container. This is in a sense unfixable unless you can temporarily disable these slots in some way.

This may be the reason why the original universal terminal does not support the installation of Pattern. Because the GUI comes directly from the AE2 code, it cannot be modified by some simple way. Unless a method similar to Mixin is used

@zeng-github01
Copy link
Contributor Author

@ChromaPIE I figured out a possible solution. Will fix this in the future

@zeng-github01 zeng-github01 marked this pull request as draft November 29, 2024 07:35
@zeng-github01
Copy link
Contributor Author

@NotMyWing The quickest way to fix this is to change the NBT Tag Name. Both Pattern and Crafting use "crafting Grid" as the Tag Name. This causes this problem

I will submit a PR in AE2UEL to fix this issue.

@zeng-github01
Copy link
Contributor Author

@ChromaPIE Fixed

@zeng-github01 zeng-github01 marked this pull request as ready for review December 5, 2024 12:31
@zeng-github01
Copy link
Contributor Author

zeng-github01 commented Dec 5, 2024

@ChromaPIE I can't find the cause of the crash caused by Mekeng and AE2FC not being installed, so I can't fix this problem for now. I have only fixed the problem that caused the item duplication.

Finally, I chose to use Mixin to fix it directly instead of modifying AE2UEL.

@ChromaPIE
Copy link
Contributor

ChromaPIE commented Dec 5, 2024

@ChromaPIE I can't find the cause of the crash caused by Mekeng and AE2FC not being installed, so I can't fix this problem for now. I have only fixed the problem that caused the item duplication.

i dont know if it will be of some help or not but you can have a look at https://github.com/ChromaPIE/NAE2/tree/for-build-2, in this branch I brutally deleted stuff in ChromaPIE@1f6114f and the other two commits after this that might be related to MekEng (but not FCR bc i got that mod so i need the compat) and it's built and working.

We might have to wait a little longer for Neeve's complete comeback.

btw, problem fixed, awesome! but still, about my suggestions of improving this, you can leave the rest for the future except: a new keybind to open the terminal. it wont make sense if it's able to put it inside bauble slot but no way to use it besides taking it out.

but that brings a new headache too: how to cycle through the modes when it's in bauble?

@zeng-github01
Copy link
Contributor Author

zeng-github01 commented Dec 5, 2024

@ChromaPIE Regarding the bauble issue, my attitude is that this is just a lazy approach. Because the wireless terminal has a base class, it defaults to making the item can be put into bauble, I don't really plan to support it for the time being. It's just because this base class can save some code... LOL

@ChromaPIE
Copy link
Contributor

understandable. might as well just remove the bauble support from it

@zeng-github01
Copy link
Contributor Author

@ChromaPIE I'm thinking about porting fluid filler from EC to AE2FC, but there is no suitable texture. Do you think it should be ported? It is not often used, but it is a pity to delete it.

@zeng-github01 zeng-github01 marked this pull request as draft December 5, 2024 17:11
@ChromaPIE
Copy link
Contributor

personally i don't think that's necessary

@zeng-github01 zeng-github01 marked this pull request as ready for review December 6, 2024 15:44
@zeng-github01
Copy link
Contributor Author

@ChromaPIE Fixed conversion bug when upgrading to universal terminal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Migrate Extracell/Aeadditions
2 participants