Modernize TPA6130A2 driver #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This properly reflects the system's physical and logical layout.
This one was also mis-named, which was confusing at first.
|
Also, this has been tested and is functional (on my system, at least). Further testing is welcome! |
|
Ross and I generally operate as JIT compilers, so we'll get around to it closer to next spring. I'm teaching the class in the fall, so I might have time to get around to this in the fall. |
|
In that case, I'll also rebase #11 on top of this — that way, they can be merged in sequence once (if?) you're ready. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the TPA6130A2 (headphone amplifier) driver, following the style of @tvannoy's minimal AD1939 driver.
As noted in #10, the old module was incorrectly named
tpa613a2— that chip does exist, but it lacks an I2C control interface. As part of this rewrite, all such mis-namings have been fixed.As an added bonus, this might make issue diagnostics a bit easier; if students see errors referencing the old name, we'll know they haven't properly migrated to the new driver.
Also, this PR doesn't implement the "mute upon module unload" behavior discussed in #10 — that's probably best reserved for a different PR.
Resolves #10