Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use final spec values for splicing #2887

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use final spec values for splicing #2887

wants to merge 1 commit into from

Commits on Oct 18, 2024

  1. Use official splice messages 

    We replace our experimental version of `splice_init`, `splice_ack` and
`splice_locked` by their official version. If our peer is using the
experimental feature bit, we convert our outgoing messages to use the
experimental encoding and incoming messages to the official messages.

We also change the TLV fields added to `tx_add_input`, `tx_signatures`
and `splice_locked` to match the spec version. We always write both the
official and experimental TLV to updated nodes (because the experimental
one is odd and will be ignored) but we drop the official TLV if our
peer is using the experimental feature, because it won't understand the
even TLV field.

This guarantees backwards-compatibility with peers who only support the
experimental feature.
    @t-bast
    t-bast committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    315c51b View commit details
    Browse the repository at this point in the history