Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use psbt to fund and sign transactions #2120

Closed
wants to merge 1 commit into from
Closed

Use psbt to fund and sign transactions #2120

wants to merge 1 commit into from

Conversation

sstone
Copy link
Member

@sstone sstone commented Jan 3, 2022

Based on #2038. We use bitcoin-kmp's Psbt classes and methods directly (there is no need for a wrapper here imho).

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #2120 (d864edb) into master (0de91f4) will decrease coverage by 0.02%.
The diff coverage is 88.09%.

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
- Coverage   84.88%   84.85%   -0.03%     
==========================================
  Files         198      198              
  Lines       15796    15841      +45     
  Branches      658      675      +17     
==========================================
+ Hits        13408    13442      +34     
- Misses       2388     2399      +11     
Impacted Files Coverage Δ
...ala/fr/acinq/eclair/blockchain/OnChainWallet.scala 100.00% <ø> (ø)
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 86.16% <ø> (ø)
...q/eclair/channel/publish/ReplaceableTxFunder.scala 85.64% <82.14%> (-1.27%) ⬇️
...ir/blockchain/bitcoind/rpc/BitcoinCoreClient.scala 94.73% <100.00%> (-1.63%) ⬇️
...q/eclair/channel/fsm/ChannelOpenSingleFunded.scala 94.16% <100.00%> (-0.03%) ⬇️
...fr/acinq/eclair/channel/InteractiveTxBuilder.scala 84.55% <0.00%> (-1.05%) ⬇️
...clair/channel/publish/ReplaceableTxPublisher.scala 74.19% <0.00%> (+0.64%) ⬆️

@sstone sstone force-pushed the use-psbt-kmp branch 3 times, most recently from 1d42c85 to baad47a Compare January 10, 2022 19:56
@sstone sstone force-pushed the use-psbt-kmp branch 2 times, most recently from e8ccb76 to 21edab9 Compare January 25, 2022 15:50
@sstone sstone force-pushed the use-psbt-kmp branch 2 times, most recently from 2f2eecd to 7518f61 Compare February 1, 2022 10:44
@sstone sstone changed the title Use psbt kmp Use psbt to fund and sign transactions Feb 2, 2022
@sstone sstone force-pushed the use-psbt-kmp branch 3 times, most recently from 9f5d181 to 8e7a4c0 Compare February 10, 2022 16:30
@sstone sstone force-pushed the use-psbt-kmp branch 2 times, most recently from 231c6ff to 8b00ece Compare July 4, 2022 08:17
@sstone sstone force-pushed the use-psbt-kmp branch 3 times, most recently from fb5521f to d888049 Compare July 19, 2022 15:46
@sstone sstone marked this pull request as ready for review July 19, 2022 16:09
@sstone sstone requested a review from t-bast July 20, 2022 13:21
@sstone
Copy link
Member Author

sstone commented Mar 16, 2023

Not needed anymore, see #2613

@sstone sstone closed this Mar 16, 2023
@sstone sstone deleted the use-psbt-kmp branch May 16, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants