Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ci/cd to stop running image comparisons #176

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

sunroofgod
Copy link
Collaborator

@sunroofgod sunroofgod commented Oct 27, 2024

Changes:

  • added CI=true value on yaml file to stop automatic running of image comparison tests in test_001_plotter.R
  • refactored formatting of unit tests in test_001_plotter.R

Note:

  • on dev side, moving forward, if we ever want to add new tests for various conditions, we can set env variables via .Rnenviron files in root directory file of the project. To load these environment variables, we can run readRenviron(".Renviron") in console before running the tests.

  • CI/CD not fully fix yet:

Screenshot 2024-10-27 at 16 30 37

However, image comparison tests are being skipped successfully and tests are all passing

Screenshot 2024-10-27 at 16 34 26

For now, since R-CMD-CHECK is "failing" on CI/CD due to "warnings", not pressing to be fixed yet. Will try to fix in next CI/CD related PR.

@sunroofgod sunroofgod merged commit e7a1bdf into dev Oct 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant