Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct results coloring #142

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Correct results coloring #142

merged 7 commits into from
Nov 28, 2024
+246 −151

Conversation

ChristofferGamel
Copy link
Contributor

@ChristofferGamel ChristofferGamel commented Nov 26, 2024 •
edited by AndreasBM1
Loading

Description

What is added/changed/removed

image

Issue/fixes reference

None, verbal agreement

Testing

Run a quiz

Checks

  • Updated / added tests for these changes
  • PHPunit locally passed
  • Codesniffer locally passed
  • Behat locally passed

EmilChri
EmilChri requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@EmilChri EmilChri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be made behat tests for this functionality

AndreasBM1
AndreasBM1 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@AndreasBM1 AndreasBM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vjohns22
vjohns22 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@vjohns22 vjohns22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTLG

@ChristofferGamel ChristofferGamel merged commit 22388b1 into staging Nov 28, 2024
3 checks passed
@ChristofferGamel ChristofferGamel deleted the correct-results-coloring branch November 28, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBM1 AndreasBM1 AndreasBM1 approved these changes

@EmilChri EmilChri EmilChri approved these changes

@vjohns22 vjohns22 vjohns22 approved these changes

@adomasciplys adomasciplys Awaiting requested review from adomasciplys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristofferGamel @vjohns22 @EmilChri @AndreasBM1