Skip to content

Commit

Permalink
fix: skip analytics
Browse files Browse the repository at this point in the history
  • Loading branch information
9renpoto committed Oct 6, 2023
1 parent 98a0024 commit dfee6ed
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 101 deletions.
95 changes: 0 additions & 95 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,98 +78,3 @@ jobs:
with:
parallel-finished: true

analyze:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4

- name: Set up node
uses: actions/setup-node@v3
with:
node-version: 'lts/*'

- name: Install dependencies
uses: bahmutov/npm-install@v1

- name: Restore next build
uses: actions/cache@v3
id: restore-build-cache
env:
cache-name: cache-next-build
with:
# if you use a custom build directory, replace all instances of `.next` in this file with your build directory
# ex: if your app builds to `dist`, replace `.next` with `dist`
path: .next/cache
# change this if you prefer a more strict cache
key: ${{ runner.os }}-build-${{ env.cache-name }}

- name: Build next.js app
run: npm run build --workspace @app/web

- name: Analyze bundle
run: npm run nextjs-bundle-analysis report --workspace @app/web

- name: Upload bundle
uses: actions/upload-artifact@v3
with:
name: bundle
path: apps/web/.next/analyze/__bundle_analysis.json

- name: Download base branch bundle stats
uses: dawidd6/action-download-artifact@v2
if: success() && github.event.number
with:
workflow: nextjs_bundle_analysis.yml
branch: ${{ github.event.pull_request.base.ref }}
path: apps/web/.next/analyze/base

# And here's the second place - this runs after we have both the current and
# base branch bundle stats, and will compare them to determine what changed.
# There are two configurable arguments that come from package.json:
#
# - budget: optional, set a budget (bytes) against which size changes are measured
# it's set to 350kb here by default, as informed by the following piece:
# https://infrequently.org/2021/03/the-performance-inequality-gap/
#
# - red-status-percentage: sets the percent size increase where you get a red
# status indicator, defaults to 20%
#
# Either of these arguments can be changed or removed by editing the `nextBundleAnalysis`
# entry in your package.json file.
- name: Compare with base branch bundle
if: success() && github.event.number
run: ls -laR apps/web/.next/analyze/base && npm run nextjs-bundle-analysis compare --workspace @app/web

- name: Get comment body
id: get-comment-body
if: success() && github.event.number
run: |
body=$(cat apps/web/.next/analyze/__bundle_analysis_comment.txt)
body="${body//'%'/'%25'}"
body="${body//$'\n'/'%0A'}"
body="${body//$'\r'/'%0D'}"
echo "body=$body" >> "$GITHUB_OUTPUT"
- name: Find Comment
uses: peter-evans/find-comment@v2
if: success() && github.event.number
id: fc
with:
issue-number: ${{ github.event.number }}
body-includes: '<!-- __NEXTJS_BUNDLE -->'

- name: Create Comment
uses: peter-evans/[email protected]
if: success() && github.event.number && steps.fc.outputs.comment-id == 0
with:
issue-number: ${{ github.event.number }}
body: ${{ steps.get-comment-body.outputs.body }}

- name: Update Comment
uses: peter-evans/[email protected]
if: success() && github.event.number && steps.fc.outputs.comment-id != 0
with:
issue-number: ${{ github.event.number }}
body: ${{ steps.get-comment-body.outputs.body }}
comment-id: ${{ steps.fc.outputs.comment-id }}
edit-mode: replace
6 changes: 0 additions & 6 deletions apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"build": "next build",
"dev": "next dev",
"start": "next start",
"nextjs-bundle-analysis": "npx -p nextjs-bundle-analysis",
"test": "playwright test"
},
"dependencies": {
Expand All @@ -21,10 +20,5 @@
"devDependencies": {
"@playwright/test": "^1.38.1",
"@types/gtag.js": "^0.0.13"
},
"nextBundleAnalysis": {
"budget": 358400,
"budgetPercentIncreaseRed": 20,
"showDetails": true
}
}

0 comments on commit dfee6ed

Please sign in to comment.