Added limit posts by post type #3
Conversation
|
Thanks for the contribution :) I will have a look at the code to see if everything works ok and then I will merge commit the pull request. |
| @@ -40,6 +40,8 @@ | |||
| <input name="wpsite_limit_posts_settings_all_users" type="radio" value="capability" <?php echo isset($settings['all']) && $settings['all'] == 'capability' ? 'checked="checked"' : ''; ?>><label><?php _e('Role', self::$text_domain); ?></label><br /> | |||
|
|
|||
| <input name="wpsite_limit_posts_settings_all_users" type="radio" value="user" <?php echo isset($settings['all']) && $settings['all'] == 'user' ? 'checked="checked"' : ''; ?>><label><?php _e('User', self::$text_domain); ?></label> | |||
|
|
|||
| <input name="wpsite_limit_posts_settings_all_users" type="radio" value="post_type" <?php echo isset($settings['all']) && $settings['all'] == 'post_type' ? 'checked="checked"' : ''; ?>><label><?php _e('Post Type', self::$text_domain); ?></label> | |||
There was a problem hiding this comment.
I would remove this line since the Limit by Post Type option should be independent from the Limit by User
|
This feature enhancement seems to only check if the current post is of a certain post type before a user tries to publish the post. Was this the intention of this feature, or did you want a certain user to be limited in number to the amount of posts they can publish of a certain post type? |
|
I wrote the code to limit post type creation gracefully for all users, I really like your approach. But I agree that for it to be ready to push to the repository it should also allow limitation of post type creation by users and caps. |
|
To really make this feature great I think we will need to add this functionality:
Once you have built in this functionality I will be happy to merge :) |
No description provided.