-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weighted temperature sensors and power device (#46, #47, #48, #49, #50, #51) #52
base: master
Are you sure you want to change the base?
Conversation
Also avoid divide by zero when intemp equals last in temp
- remove rounding for constC and ConstT - always learn over a period of 2 days - allow for weighted averaging on temp sensors (if a sensor is listed twice that sensor will weigh twice in the average temperature)
+1 for these double digits. I implemented that myself before, but lost it during a plugin update. I forgot that I changed it until I saw your comment. Same reason, with only 1 digit especially the ConstT parameter hardly changes, since it is already a very small number. |
Apologies for a long silence…. I am now resuming attention to the plugin and will review your PR over the holidays. Many thanks for contributing |
Hi all, I have tried this PR for a while and suggest following improvements:
|
As explained in the mentioned issues here are some changes I made to your excellent thermostat to make it better match my needs. I hope others can benefit from these changes too.