Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line option --ignore-all-reference-configs/-nc. #2187

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented Sep 12, 2024

  • Add role app boot bindings to control inclusion of reference role configs and reference common configs.

  • Change default behavior of explicit role configs: include role reference configs as fallbacks by default.

  • Read DebugProperties sysprops directly in role app boot bindings instead of merging DebugProperties sysprops with bindings later

Add role app boot bindings to control inclusion of reference role configs and reference common configs.

Change default behavior of explicit role configs: include role reference configs as fallbacks by default.

Read sysprops directly in role app boot bindings instead of merging sysprops with bindings later
@neko-kai neko-kai requested a review from pshirshov as a code owner September 12, 2024 22:24
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.62%. Comparing base (d2d29dc) to head (b97c5dc).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2187      +/-   ##
===========================================
+ Coverage    66.57%   66.62%   +0.04%     
===========================================
  Files          593      594       +1     
  Lines        11611    11627      +16     
  Branches      1332     1388      +56     
===========================================
+ Hits          7730     7746      +16     
  Misses        3881     3881              

@neko-kai neko-kai merged commit a888329 into develop Sep 17, 2024
33 checks passed
@neko-kai neko-kai deleted the feature/fix-config-order-again-again branch September 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant