Better logger config #2170
Merged
Better logger config #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2170 +/- ##
========================================
Coverage 66.55% 66.56%
========================================
Files 592 593 +1
Lines 11533 11566 +33
Branches 1316 1331 +15
========================================
+ Hits 7676 7699 +23
- Misses 3857 3867 +10 |
pshirshov
force-pushed
the
wip/cleaner-logger-config
branch
from
a079120 to
d4f4843
Compare
neko-kai
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major cleanup. Switched to
WildcardPrefixTreeThere are several important improvements:
my.package.*.something)ConfigurableLogRouternow supports specifying different sinks for different prefixes (previously it only supported one set of sinks). This can be configured programmatically but not in the config (yet?)