Documentation, reorganization and additon of new methods #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germartinez
changed the title
mmv08
approved these changes
Feb 10, 2021
src/CPK.ts
Outdated
| */ | ||
| get address(): Promise<Address | undefined> { | ||
| if (this.#safeAppsSdkConnector?.isSafeApp) { | ||
| return (async () => this.#safeAppsSdkConnector && (await this.#safeAppsSdkConnector.getSafeInfo()).safeAddress)() |
There was a problem hiding this comment.
I'm definitely lacking knowledge on the architecture of cpk and stuff, but is it possible to cache the address when connecting?
Comment on lines
+14
to
+15
| this.#appsSdk.getSafeInfo().then((appInfo: SafeInfo) => { | ||
| this.#isSafeApp = !!appInfo.safeAddress |
There was a problem hiding this comment.
here you go, I think you can just save the address and remove the async getter
src/utils/networks.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| type Networks = { | |||
| [key: string]: number | |||
There was a problem hiding this comment.
to be more precise I think we can also define a type for network names
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #133, #89 and #139