Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable test builds #108

Draft
wants to merge 18 commits into
base: development
Choose a base branch
from
Draft

Reenable test builds #108

wants to merge 18 commits into from

Conversation

cag
Copy link
Contributor

@cag cag commented Sep 21, 2020

(For Geth and OpenEthereum support)

@cag cag force-pushed the reenable-test-builds branch from 174779a to 59daba8 Compare October 27, 2020 16:07
@cag cag requested a review from germartinez November 9, 2020 20:05
@cag cag changed the base branch from master to development November 9, 2020 20:20
Copy link
Member

@germartinez germartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see travis.yml includes tests against Ganache and Open Ethereum again using gunash 👍
I think Geth is missing, isn't it? https://github.com/cag/gunash/blob/main/index.js#L51
Should we also add Nethermind? https://github.com/cag/gunash/blob/main/index.js#L82

@cag
Copy link
Contributor Author

cag commented Dec 17, 2020

I tried testing with Geth but now it's actually failing with the relayer, possibly because they now actually error in their own way on eth_call failures instead of succeeding with the revert data as the return data, though I'm not entirely sure.

As for Nethermind, I keep running into issues. Like there's this issue, which indeed did get solved, but also in the same release that that issue got solved, Nethermind locked down their dev accounts behind a password that can only be gotten from the stdout of the node process, and since Gunash relies on Docker, that stdout output has to be gotten via a separate process listening for the data on the Docker logs. Anyway, it's not impossible, but it is definitely a wrench.

@germartinez germartinez marked this pull request as draft September 3, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants