-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable test builds #108
base: development
Are you sure you want to change the base?
Reenable test builds #108
Conversation
174779a
to
59daba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see travis.yml includes tests against Ganache and Open Ethereum again using gunash 👍
I think Geth is missing, isn't it? https://github.com/cag/gunash/blob/main/index.js#L51
Should we also add Nethermind? https://github.com/cag/gunash/blob/main/index.js#L82
I tried testing with Geth but now it's actually failing with the relayer, possibly because they now actually error in their own way on As for Nethermind, I keep running into issues. Like there's this issue, which indeed did get solved, but also in the same release that that issue got solved, Nethermind locked down their dev accounts behind a password that can only be gotten from the stdout of the node process, and since Gunash relies on Docker, that stdout output has to be gotten via a separate process listening for the data on the Docker logs. Anyway, it's not impossible, but it is definitely a wrench. |
(For Geth and OpenEthereum support)